Skip to content

feat: integration tests #572

Merged
kylemcd merged 52 commits intomainfrom
kyle-kno-8705-sdk-implement-tests-that-run-with-different-versions-of
Jun 5, 2025
Merged

feat: integration tests #572
kylemcd merged 52 commits intomainfrom
kyle-kno-8705-sdk-implement-tests-that-run-with-different-versions-of

Conversation

@kylemcd
Copy link
Member

@kylemcd kylemcd commented Jun 3, 2025 •
edited
Loading

Description

Sorry for the super long commit log (yay CI changes)

  • Adds @knocklabs/integration to run integration tests on our package.
  • Adds integration test runner for running test suite in CI.
  • Adds README for using the integration test suite.

More information on the test suite and the architecture chosen can be found in the README.

@linear
Copy link

linear bot commented Jun 3, 2025

KNO-8705 [SDK] Implement tests that run with different versions of react

@vercel
Copy link

vercel bot commented Jun 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-ms-teams-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 3:10pm
javascript-nextjs-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 3:10pm
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 3:10pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 3:10pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e515d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kylemcd Graphite App
Copy link
Member Author

kylemcd commented Jun 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kylemcd kylemcd force-pushed the kyle-kno-8705-sdk-implement-tests-that-run-with-different-versions-of branch from fef5cd6 to 6e05496 Compare June 4, 2025 22:00
@kylemcd kylemcd changed the title feat: run ci for multiple react versions feat: integration tests Jun 4, 2025
mattmikolay
mattmikolay approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@mattmikolay mattmikolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly excellent! Thanks for the thorough README file as well.

mattmikolay
mattmikolay reviewed Jun 5, 2025
View reviewed changes
connorlindsey
connorlindsey approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@connorlindsey connorlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kylemcd kylemcd merged commit 2210e6a into main Jun 5, 2025
11 checks passed
@kylemcd kylemcd deleted the kyle-kno-8705-sdk-implement-tests-that-run-with-different-versions-of branch June 5, 2025 16:42
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.74%. Comparing base (164af54) to head (50c727c).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   23.74%   23.74%           
=======================================
  Files         180      180           
  Lines        6775     6775           
  Branches      212      212           
=======================================
  Hits         1609     1609           
+ Misses       5166     5140   -26     
- Partials        0       26   +26

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattmikolay mattmikolay mattmikolay approved these changes

@connorlindsey connorlindsey connorlindsey approved these changes

@meryldakin meryldakin Awaiting requested review from meryldakin meryldakin is a code owner automatically assigned from knocklabs/product

@cjbell cjbell Awaiting requested review from cjbell

@thomaswhyyou thomaswhyyou Awaiting requested review from thomaswhyyou

@MikeCarbone MikeCarbone Awaiting requested review from MikeCarbone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kylemcd @mattmikolay @connorlindsey